#804 - Bug Fix - Empty divs are created#1218
Merged
epicfaace merged 2 commits intorjsf-team:masterfrom Mar 14, 2019
Merged
Conversation
epicfaace
requested changes
Mar 13, 2019
Member
|
Looks great! Thanks |
epicfaace
approved these changes
Mar 14, 2019
|
Has this been released on npm? Edit: Nevermind I realized that this is one of the commits to master since last release. |
Member
|
@Jigsaw-Jams it now has. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Multiple empty divs seem to be created that are not useful. So removing the empty divs
Resolves #804
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style